Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : updated n_jobs docs in Parallel class #1537

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

Schefflera-Arboricola
Copy link
Contributor

fixes #1536

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (6310841) to head (e99fc67).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   95.16%   95.12%   -0.04%     
==========================================
  Files          44       44              
  Lines        7562     7583      +21     
==========================================
+ Hits         7196     7213      +17     
- Misses        366      370       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomMoral
Copy link
Contributor

tomMoral commented Jan 4, 2024

I don't think this is true.

The behavior of joblib depends on the backend through get_effective_n_jobs and there is no condition based on the number of CPUs.

The rational for not limiting the number of workers with the number of CPUs is that in some situation, a slight over subscription (using n_jobs > n_cpus) is beneficial.

@Schefflera-Arboricola
Copy link
Contributor Author

Thanks @tomMoral!

@tomMoral
Copy link
Contributor

tomMoral commented Apr 3, 2024

Thanks for the PR, I did a small rewording, will merge this asap.

@tomMoral tomMoral merged commit c2087db into joblib:main Apr 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What happens when n_jobs > os.cpu_count()?
2 participants