Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Close cleanly distributed Client at the end of unit tests #1526

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

fcharras
Copy link
Contributor

@fcharras fcharras commented Nov 23, 2023

The distributed pipeline seemed to be less stable after #1520 , all tests do pass and there is no deadlock but the python interpreter terminates with an error code and outputs a long traceback related to backend termination.

This PR might help fix that, it ensures that when a distributed.Client is opened locally in unit tests, it is also closed cleanly before exiting the test (like it has always been done in https://github.com/joblib/joblib/blob/master/joblib/test/test_dask.py but was overlooked in https://github.com/joblib/joblib/blob/master/joblib/test/test_parallel.py )

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebfe05d) 95.06% compared to head (3ea275c) 95.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   95.06%   95.06%   -0.01%     
==========================================
  Files          44       44              
  Lines        7564     7562       -2     
==========================================
- Hits         7191     7189       -2     
  Misses        373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. The test logs look much cleaner now!

@ogrisel ogrisel merged commit 6310841 into joblib:master Dec 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants