Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README cloning url #1508

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix README cloning url #1508

merged 1 commit into from
Sep 29, 2023

Conversation

andreaso
Copy link
Contributor

GitHub does, for good reasons, no longer support the git:https:// protocol.

https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0569c89) 95.01% compared to head (f57b806) 94.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   95.01%   94.94%   -0.08%     
==========================================
  Files          45       45              
  Lines        7550     7550              
==========================================
- Hits         7174     7168       -6     
- Misses        376      382       +6     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomMoral tomMoral merged commit 720ccd9 into joblib:master Sep 29, 2023
16 checks passed
@tomMoral
Copy link
Contributor

Thanks for the fix! merging.

@andreaso
Copy link
Contributor Author

No problem!

On a similar note, the documentation contains a bunch of http:https:// urls, where it probably would preferable to use the https:// versions instead.

Would a PR rectifying that be welcomed?

@tomMoral
Copy link
Contributor

Yes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants