Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Cleanup expired ndarray methods #1506

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Sep 17, 2023

Hi!
This PR reflects changes introduced in numpy/numpy#24682.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (bfd14eb) 94.92% compared to head (38de320) 94.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   94.92%   94.96%   +0.03%     
==========================================
  Files          45       45              
  Lines        7550     7550              
==========================================
+ Hits         7167     7170       +3     
+ Misses        383      380       -3     
Files Changed Coverage Δ
joblib/numpy_pickle_utils.py 93.25% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsokol
Copy link
Contributor Author

mtsokol commented Sep 19, 2023

Hi! Would you have a spare time to review this PR?

@lesteve lesteve merged commit 0569c89 into joblib:master Sep 19, 2023
16 checks passed
@lesteve
Copy link
Member

lesteve commented Sep 19, 2023

Merging, thanks!

@mtsokol mtsokol deleted the numpy-ndarray-class-cleanup branch September 19, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants