Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test regex for Python 3.12 improved error message #1476

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.81 ⚠️

Comparison is base (476ff8e) 94.94% compared to head (29d9511) 94.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   94.94%   94.13%   -0.81%     
==========================================
  Files          45       45              
  Lines        7474     7474              
==========================================
- Hits         7096     7036      -60     
- Misses        378      438      +60     
Impacted Files Coverage Δ
joblib/test/test_memory.py 98.40% <100.00%> (-0.13%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for the fix.

@tomMoral tomMoral merged commit 0c57c18 into joblib:master Jul 10, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants