Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double repeated word typos #1464

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

ivanov
Copy link
Contributor

@ivanov ivanov commented Jun 27, 2023

Hello there, joblib maintainers!

thank you for your hard work. I came here because a useful warning had a typo in it, "..loaded from the file redacted is not not bytes aligned." and noticed that there was another instance of a not not typo elsewhere in the repository. Unsatisfied to fix just those two "not not" instances, I decided to regex for others, and here's the result.

For the record, the incantation I used was git grep -E "\b(\w+)\s+\1\b" and the few remaining results for this are legitimate ("Matrix Matrix multiplication", for example).

Happy hacking! :bowtie:

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (5d57f3d) 94.91% compared to head (6369044) 94.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage   94.91%   94.82%   -0.10%     
==========================================
  Files          44       44              
  Lines        7439     7439              
==========================================
- Hits         7061     7054       -7     
- Misses        378      385       +7     
Impacted Files Coverage Δ
joblib/_memmapping_reducer.py 96.40% <ø> (ø)
joblib/executor.py 100.00% <ø> (ø)
joblib/numpy_pickle.py 99.14% <ø> (ø)
joblib/test/test_parallel.py 96.09% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick, thanks for the PR!

@ogrisel
Copy link
Contributor

ogrisel commented Jun 27, 2023

The scikit-learn failures are unrelated, merging.

@ogrisel ogrisel merged commit db6f6f5 into joblib:master Jun 27, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants