Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBG try to debug the thread_bomb_mitigation test #1424

Merged
merged 7 commits into from
Apr 18, 2023

Conversation

tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Apr 14, 2023

Investigation PR for #1150

From the investigation, this bug seems to be related to a bad interaction between the test, Pypy and coverage.
I propose to disable the coverage on this test to stabilize the test suite.

I was able to reproduce the failure locally by running the test with --cov=joblib and by adding the following at the beginning of the test:

def test_thread_bomb_mitigation(backend):
    def recursive():
        return recursive()
    with raises(RecursionError):
        recursive()

This could be investigated further if someone has the time to do so.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (60ec53d) 94.76% compared to head (8b4e5b8) 94.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   94.76%   94.75%   -0.01%     
==========================================
  Files          45       45              
  Lines        6890     6918      +28     
==========================================
+ Hits         6529     6555      +26     
- Misses        361      363       +2     
Impacted Files Coverage Δ
joblib/test/test_parallel.py 96.07% <50.00%> (-1.08%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomMoral tomMoral marked this pull request as ready for review April 18, 2023 08:58
@tomMoral tomMoral merged commit fc6c4ce into joblib:master Apr 18, 2023
@tomMoral tomMoral deleted the DBG_test_thread_bomb_pypy branch April 18, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant