Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Clean deprecations #1397

Merged
merged 2 commits into from
Feb 21, 2023
Merged

MAINT Clean deprecations #1397

merged 2 commits into from
Feb 21, 2023

Conversation

jeremiedbb
Copy link
Contributor

They were supposed to be removed in 0.16 😄

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 93.89% // Head: 94.75% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (09562d2) compared to base (e4c00de).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
+ Coverage   93.89%   94.75%   +0.85%     
==========================================
  Files          52       46       -6     
  Lines        7341     6942     -399     
==========================================
- Hits         6893     6578     -315     
+ Misses        448      364      -84     
Impacted Files Coverage Δ
joblib/my_exceptions.py 100.00% <ø> (+13.33%) ⬆️
joblib/test/test_parallel.py 97.13% <ø> (+0.08%) ⬆️
joblib/hashing.py 89.47% <0.00%> (-1.76%) ⬇️
joblib/testing.py 95.23% <0.00%> (ø)
joblib/test/test_testing.py 100.00% <0.00%> (ø)
joblib/test/test_numpy_pickle.py 94.24% <0.00%> (+<0.01%) ⬆️
joblib/memory.py 95.52% <0.00%> (+0.26%) ⬆️
joblib/_parallel_backends.py 94.85% <0.00%> (+3.30%) ⬆️
joblib/test/testutils.py 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup.

@ogrisel
Copy link
Contributor

ogrisel commented Feb 21, 2023

The PyPy failure is unrelated. Merging.

@ogrisel ogrisel merged commit be0e384 into joblib:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants