Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH make temp resource cleanup safer #1391

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

tomMoral
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 93.94% // Head: 94.01% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (1928888) compared to base (061d4ad).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
+ Coverage   93.94%   94.01%   +0.07%     
==========================================
  Files          52       52              
  Lines        7328     7307      -21     
==========================================
- Hits         6884     6870      -14     
+ Misses        444      437       -7     
Impacted Files Coverage Δ
joblib/test/test_memmapping.py 99.24% <ø> (ø)
joblib/_memmapping_reducer.py 96.40% <100.00%> (+0.51%) ⬆️
joblib/_parallel_backends.py 95.22% <100.00%> (+2.20%) ⬆️
joblib/executor.py 100.00% <100.00%> (ø)
joblib/pool.py 87.80% <100.00%> (ø)
joblib/hashing.py 89.47% <0.00%> (-1.76%) ⬇️
joblib/memory.py 95.52% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glemaitre glemaitre self-requested a review February 17, 2023 16:37
@tomMoral tomMoral merged commit df12286 into joblib:master Feb 21, 2023
@tomMoral tomMoral deleted the ENH_safer_temp_resource_cleanup branch February 21, 2023 17:34
fcharras added a commit to fcharras/joblib that referenced this pull request Apr 14, 2023
fcharras added a commit to fcharras/joblib that referenced this pull request Apr 14, 2023
fcharras added a commit to fcharras/joblib that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant