Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the metadata into pyproject.toml #1382

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 94.01% // Head: 93.91% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (f7a4e93) compared to base (6836640).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
- Coverage   94.01%   93.91%   -0.10%     
==========================================
  Files          52       52              
  Lines        7300     7300              
==========================================
- Hits         6863     6856       -7     
- Misses        437      444       +7     
Impacted Files Coverage Δ
joblib/test/testutils.py 50.00% <0.00%> (-50.00%) ⬇️
joblib/_parallel_backends.py 93.38% <0.00%> (-1.11%) ⬇️
joblib/parallel.py 96.03% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a try and it seems to work as expected. Here are the commands I tried:

python setup.py bdist_wheel
python setup.py sdist
pip install -e .
python -m build  # pep 517

I also tried to install the wheel and tarball generated by python -m build in a new empty env and do basic joblib parallel calls and it works as expected.

"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are at it:

Suggested change
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",

@ogrisel
Copy link
Contributor

ogrisel commented Feb 15, 2023

Hum I cannot accept my own suggestion, let merge and I will update the metadata later.

@ogrisel ogrisel merged commit 5ab41fb into joblib:master Feb 15, 2023
@ogrisel
Copy link
Contributor

ogrisel commented Feb 15, 2023

Thanks @KOLANICH!

@KOLANICH KOLANICH deleted the pyproject.toml branch February 15, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants