Fix memmapping_reducer when 'os' has no attribute 'statvfs' #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.92% // Head: 93.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
=======================================
Coverage 93.92% 93.93%
=======================================
Files 52 52
Lines 7291 7300 +9
=======================================
+ Hits 6848 6857 +9
Misses 443 443
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #902
In this case when 'os' has no attribute 'statvfs' we don't use
/dev/shmeven if it exists, as we are then not able to determine how much free space it has.The other possible solution could be to ignore
SYSTEM_SHARED_MEM_FS_MIN_SIZEand still write to/dev/shm.The typical use case where this could happen is when running a Linux like system on Windows (which doesn't have statvfs apparently). I'm not sure what would be better.