Drop runtime dependency on distutils
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distutils` is going away in Python 3.12 and is deprecated from Python 3.10 onwards. It's also kinda slow to import. This import was kept around to avoid breaking scikit-learn, however it's now been long enough since scikit-learn deployed a fix that it should be safe to remove this.
Codecov ReportBase: 94.02% // Head: 93.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
- Coverage 94.02% 93.99% -0.03%
==========================================
Files 52 52
Lines 7292 7291 -1
==========================================
- Hits 6856 6853 -3
- Misses 436 438 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Not sure what's up with the docs build. It seems to have hit a permissions issue, though I'm not sure if/how that's related to these changes. |
tomMoral
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
LGTM! thanks for the PR @PeterJCLaw
The doc builid error is on master so I will merge this one as it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutilsis going away in Python 3.12 and is deprecated from Python 3.10 onwards. It's also kinda slow to import. This import was kept around to avoid breaking scikit-learn, however it's now been long enough since scikit-learn deployed a fix (scikit-learn 1.1 was released in May 2022) that it should be safe to remove this.As discussed in #1277 (comment)