allow TLS 1.3 ciphersuites after 3DES suites and Go 1.13.1 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ciphersuites for TLS 1.3 are fine to come after any 3DES suites because they are a completely disjoint set from any previous versions TLS 1.2 version. Older versions of TLS don't support them, and TLS 1.3 doesn't support the older ciphersuites. This came up because Go 1.13 and later are sending them by default now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ciphersuites for TLS 1.3 are fine to come after any 3DES suites because they
are a completely disjoint set from any previous versions TLS 1.2 version. Older
versions of TLS don't support them, and TLS 1.3 doesn't support the older
ciphersuites.
This came up because Go 1.13 and later are sending them by default now.
We also do an upgrade to Go 1.13.1 because I wasn't able to get a local development environment that matched what was currently in howsmyssl's CI. Welp.