return 200 for blocked JSONP requests #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, when you do a <script src="yadda?callback=parseTLSThing">, the script won't run if a 4xx error code is returned. So, in order for folks to show errors to their users, and not just quietly log in their console, we have to return 200 OK even on blocked domains. To be clear, normal AJAX requests would work, but people do that script tag thing to be JSONP-y. This patch also includes some new tests (and, along the way, a refactoring of the current ones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, when you do a <script src="yadda?callback=parseTLSThing">, the script
won't run if a 4xx error code is returned. So, in order for folks to show errors
to their users, and not just quietly log in their console, we have to return 200
OK even on blocked domains.
To be clear, normal AJAX requests would work, but people do that script tag
thing to be JSONP-y.
This patch also includes some new tests (and, along the way, a refactoring of
the current ones).