fix(cli): Fix panic on argo template lint without argument (argoproj#…

…4300)
jlegrone · Oct 20, 2020 · aa4a435 · aa4a435
1 parent 640998e
commit aa4a435
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/cmd/argo/commands/template/lint.go b/cmd/argo/commands/template/lint.go
@@ -24,6 +24,10 @@ func NewLintCommand() *cobra.Command {
  Use: "lint (DIRECTORY | FILE1 FILE2 FILE3...)",
  Short: "validate a file or directory of workflow template manifests",
  Run: func(cmd *cobra.Command, args []string) {
+ if len(args) == 0 {
+ cmd.HelpFunc()(cmd, args)
+ os.Exit(1)
+ }
  err := ServerSideLint(args, strict)
  if err != nil {
  log.Fatal(err)

diff --git a/test/e2e/cli_test.go b/test/e2e/cli_test.go
@@ -725,6 +725,14 @@ func (s *CLIWithServerSuite) TestWorkflowWatch() {
 }
 
 func (s *CLISuite) TestTemplate() {
+ s.Run("LintWithoutArgs", func() {
+ s.Given().RunCli([]string{"template", "lint"}, func(t *testing.T, output string, err error) {
+ if assert.Error(t, err) {
+ assert.Contains(t, output, "Usage:")
+ }
+ })
+ })
+
  s.Run("Lint", func() {
  s.Given().RunCli([]string{"template", "lint", "smoke/workflow-template-whalesay-template.yaml"}, func(t *testing.T, output string, err error) {
  if assert.NoError(t, err) {