fix: Panic on releaseAllWorkflowLocks if Object is not Unstructured t…

…ype (argoproj#3504)

workflow/controller/controller.go

@@ -838,12 +838,16 @@ func (wfc *WorkflowController) releaseAllWorkflowLocks(obj interface{}) {
  un, ok := obj.(*unstructured.Unstructured)
  if !ok {
  log.Warnf("Key '%s' in index is not an unstructured", obj)
+ return
  }
  wf, err := util.FromUnstructured(un)
  if err != nil {
  log.Warnf("Invalid workflow object: %v", obj)
+ return
+ }
+ if wf.Status.Synchronization != nil {
+ wfc.syncManager.ReleaseAll(wf)
  }
- wfc.syncManager.ReleaseAll(wf)
 }
 
 func (wfc *WorkflowController) isArchivable(wf *wfv1.Workflow) bool {

workflow/controller/controller_test.go

@@ -5,6 +5,7 @@ import (
  "testing"
  "time"
 
+ "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
  "k8s.io/apimachinery/pkg/labels"
  "k8s.io/client-go/tools/record"
 
@@ -424,3 +425,19 @@ func TestIsArchivable(t *testing.T) {
  assert.True(t, controller.isArchivable(workflow))
  })
 }
+
+func TestReleaseAllWorkflowLocks(t *testing.T) {
+ cancel, controller := newController()
+ defer cancel()
+ t.Run("nilObject", func(t *testing.T) {
+ controller.releaseAllWorkflowLocks(nil)
+ })
+ t.Run("unStructuredObject", func(t *testing.T) {
+ un := &unstructured.Unstructured{}
+ controller.releaseAllWorkflowLocks(un)
+ })
+ t.Run("otherObject", func(t *testing.T) {
+ un := &wfv1.Workflow{}
+ controller.releaseAllWorkflowLocks(un)
+ })
+}