Skip to content

Commit

Permalink
fix(executor): artifact chmod should only if err != nil (argoproj#4409)
Browse files Browse the repository at this point in the history
  • Loading branch information
AntoineDao committed Oct 28, 2020
1 parent 2821e4e commit 3aeb174
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions USERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ Currently, the following organizations are **officially** using Argo Workflows:
1. [Graviti](https://www.graviti.cn)
1. [Greenhouse](https://greenhouse.io)
1. [Habx](https://www.habx.com/)
1. [Helio](https://helio.exchange)
1. [HOVER](https://hover.to)
1. [HSBC](https://hsbc.com)
1. [IBM](https://ibm.com)
1. [InsideBoard](https://www.insideboard.com)
1. [Interline Technologies](https://www.interline.io/blog/scaling-openstreetmap-data-workflows/)
Expand All @@ -71,6 +73,7 @@ Currently, the following organizations are **officially** using Argo Workflows:
1. [OVH](https://www.ovh.com/)
1. [Peak AI](https://www.peak.ai/)
1. [PDOK](https://www.pdok.nl/)
1. [Pollination](https://pollination.cloud)
1. [Preferred Networks](https://www.preferred-networks.jp/en/)
1. [Prudential](https://www.prudential.com.sg/)
1. [Quantibio](http:https://quantibio.com/us/en/)
Expand All @@ -96,5 +99,3 @@ Currently, the following organizations are **officially** using Argo Workflows:
1. [UFirstGroup](https://www.ufirstgroup.com)
1. [Wavefront](https://www.wavefront.com/)
1. [Wellcome Trust](https://wellcome.ac.uk/)
1. [Helio](https://helio.exchange)
1. [HSBC](https://hsbc.com)
4 changes: 3 additions & 1 deletion workflow/executor/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ func (we *WorkflowExecutor) LoadArtifacts() error {
log.Infof("Successfully download file: %s", artPath)
if art.Mode != nil {
err = chmod(artPath, *art.Mode, art.RecurseMode)
return err
if err != nil {
return err
}
}
}
return nil
Expand Down

0 comments on commit 3aeb174

Please sign in to comment.