Add setting for sort and limit #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowens
reviewed
Oct 10, 2018
| $collection->getSelect()->order(new Zend_Db_Expr('RAND()')); | ||
| if (Mage::getStoreConfigFlag('jobqueue/config/sort_random')) { | ||
| // randomly order to prevent lock contention among workers | ||
| $collection->getSelect()->order(new Zend_Db_Expr('RAND()')); |
There was a problem hiding this comment.
I don't know why this was added, it doesn't really have any benefit. Can you just remove and sort the collection by ascending ID?
There was a problem hiding this comment.
Well the comment says: randomly order to prevent lock contention among workers. With the added system config setting it's now configurable. That's more backwards compatible then just removing it.
|
Thanks for your contribution! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice of you could set a limit of jobs to process at one time. Now we run in to the problem that many new jobs are added at the same time and we're hitting a memory limit when all these jobs need to be handle in one go.
We would also like to have the possibility to run the jobs in the first in first out order instead of random.
I added two settings to manage this functionality.