Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge query string parameters in etherpad_base with app values #14931

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ntninja
Copy link
Contributor

@ntninja ntninja commented Jul 19, 2024

Allows overriding or augmenting the default values set by the Jitsi Meet web app using the config parameter.

Use case when using EtherPad may be (in config):
etherpad_base = "https://hostname/etherpad/extraordinaryparameterstiekindly?useMonospaceFont=true",

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@ntninja
Copy link
Contributor Author

ntninja commented Jul 19, 2024

@jitsi-jenkins: I have signed the CLA in the past

Allows overriding or augmenting the default values set by the Jitsi Meet web app using the config parameter.
@damencho
Copy link
Member

LGTM

@damencho
Copy link
Member

jenkins, test this please.

@saghul saghul merged commit 72779e5 into jitsi:master Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants