-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overall Codebase Enhancement #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legates implementation to the Compose Runtime.
jisungbin
changed the title
Rebuilding the entire codebase
Overall Codebase Enhancement
Jan 14, 2024
"Provide the composable invocation tree" |
I've come up with an idea to achieve this without changing the function signature. Replace every |
Tracked by #77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63.
This PR includes a substantial number of changes.
Key Changes
Snapshot.registerApplyObserver
. By relying on the core implementation in the Compose runtime, a more resilient implementation can be provided.!Composer.skipping
branch implementation. The previous approach relied on the scope of thetrace
API, but as thetrace
API can be disabled by users, it was an unstable implementation.Composer.skipToGroupEnd
andComposer.ScopeUpdateScope
implementations. By using more accurate conditions, a more robust and detailed implementation can be provided.KeyInfo
for the same composable only once initially and then reuses this value. Additionally, managesuserProvideName
andlocation
information inKeyInfo
. This effectively reduces redundant calculations.Remaining TODOs Before Release
AffectedComposable
as an argument, it is essential to cache theAffectedComposable
with thekeyName
to prevent repetitive instantiation.Preview