Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking to external style sheet #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonis
Copy link

@simonis simonis commented Dec 17, 2018

Hi,

I think in some cases it may be useful to use CSS classes but not insert the styles into the generated document (because they get included elsewhere) or just link to an external style-sheet which is maintained outside of Rouge.

Exactly this can be achieved with this change with adds the new external option to the rouge-css attribute. This change shouldn't introduce any changes to the current functionality.

Best regards,
Volker

@simonis simonis mentioned this pull request Dec 29, 2018
@gdamore
Copy link

gdamore commented May 27, 2020

Yes please!

@gdamore
Copy link

gdamore commented May 27, 2020

@jirutka this would make my life better -- in particular the EPUB formatter is very unhappy with <style> elements -- it causes EPUBs to fail validation, and some ereaders wind up ignoring the style or just putting it to the display as if it was body text (which is very, very bad).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants