-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified migration files #312
Conversation
I fixed the build. Should be back in businesss soon |
@omricohen could you somehow update that PR to trigger the build again?Thanks |
@msevestre I did -- still failed |
yeah thanks. @jipiboily is going to look into that soon :)
…On Tue, Mar 7, 2017 at 11:39 AM Omri Cohen ***@***.***> wrote:
@msevestre <https://github.com/msevestre> I did -- still failed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#312 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_jVYImMP3CwUH1l0oEjsNtaOiytILrks5rjYg3gaJpZM4MPoMc>
.
|
yeah, I want to make the build pass again shortly. :) |
@omricohen while working on making the build pass (#301) I had to resetup Monologue locally, and the migrations worked perfectly fine for me. What is this PR trying to fix/change exactly? Not 100% clear to me. Thanks! |
That's going to be more complicated than I thought. See #301 please. Happy to pay $100 if someone wants to get Monologue back on track. |
Actually, see #314 instead. |
@jipiboily This PR makes it so that you can rollback a monologue install. The current migrations do not allow for a rollback. Plus, not point in keeping so many migration 'change' files, makes it harder to maintain and understand what is going on. |
I am going to close this PR as it is polluting my Review list and is clearly outdated :) |
I removed all the migration updates and moved them into 4 their respective create migrations. This will greatly simplify new installs.