Fix the build #248
Merged
Fix the build #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,31 +43,31 @@ | |||
| describe "social icons+links" do | |||
| context "render if enabled" do | |||
| it "generate rss <link> tag for <head>" do | |||
| helper.rss_head_link.should eq "<link href=\"https://test.host/monologue/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" | |||
| helper.rss_head_link.should eq "<link href=\"https://test.host/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" | |||
There was a problem hiding this comment.
Line is too long. [141/80]
1 similar comment
| @@ -43,31 +43,50 @@ | |||
| describe "social icons+links" do | |||
| context "render if enabled" do | |||
| it "generate rss <link> tag for <head>" do | |||
| helper.rss_head_link.should eq "<link href=\"https://test.host/monologue/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" | |||
| helper.rss_head_link.should have_css("link", href: "https://test.host/feed", rel: "alternate", | |||
There was a problem hiding this comment.
Line is too long. [101/80]
There was a problem hiding this comment.
@houndci what about now?
| target: "_blank" | ||
| ) | ||
|
|
||
| helper.googleplus_icon.should have_css("i", class: "foundicon-google-plus") |
There was a problem hiding this comment.
Line is too long. [83/80]
| end | ||
|
|
||
| it "generate googleplus" do | ||
| helper.googleplus_icon.should eq "<a class=\"social\" href=\"#{Monologue::Config.google_plus_account_url}\" target=\"_blank\"><i class=\"foundicon-google-plus\"></i></a>" | ||
| helper.googleplus_icon.should have_css("a", | ||
| href: "#{Monologue::Config.google_plus_account_url}", |
There was a problem hiding this comment.
Align the parameters of a method call if they span more than one line.
3 similar comments
1 similar comment
|
Hey cool.
|
2 similar comments
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I made some changes to get Travis back to green.
There were some failing tests on application_helper_spec and I had to add responders 2.0 as a dependency for deprecation reasons.