-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build #248
Fix the build #248
Conversation
@@ -43,31 +43,31 @@ | |||
describe "social icons+links" do | |||
context "render if enabled" do | |||
it "generate rss <link> tag for <head>" do | |||
helper.rss_head_link.should eq "<link href=\"https://test.host/monologue/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" | |||
helper.rss_head_link.should eq "<link href=\"https://test.host/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [141/80]
1 similar comment
@@ -43,31 +43,50 @@ | |||
describe "social icons+links" do | |||
context "render if enabled" do | |||
it "generate rss <link> tag for <head>" do | |||
helper.rss_head_link.should eq "<link href=\"https://test.host/monologue/feed\" rel=\"alternate\" title=\"RSS\" type=\"application/rss+xml\" />" | |||
helper.rss_head_link.should have_css("link", href: "https://test.host/feed", rel: "alternate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [101/80]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houndci what about now?
target: "_blank" | ||
) | ||
|
||
helper.googleplus_icon.should have_css("i", class: "foundicon-google-plus") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [83/80]
end | ||
|
||
it "generate googleplus" do | ||
helper.googleplus_icon.should eq "<a class=\"social\" href=\"#{Monologue::Config.google_plus_account_url}\" target=\"_blank\"><i class=\"foundicon-google-plus\"></i></a>" | ||
helper.googleplus_icon.should have_css("a", | ||
href: "#{Monologue::Config.google_plus_account_url}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the parameters of a method call if they span more than one line.
3 similar comments
1 similar comment
Hey cool.
|
2 similar comments
Thanks |
Hey, I made some changes to get Travis back to green.
There were some failing tests on application_helper_spec and I had to add responders 2.0 as a dependency for deprecation reasons.