chore(ingest): upgrade sqlglot fork (datahub-project#8775)

Co-authored-by: Tamas Nemeth <[email protected]>
jinlintt · Sep 6, 2023 · 4ffad4d · 4ffad4d
1 parent f353bc7
commit 4ffad4d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 42 deletions.
diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py
@@ -136,7 +136,7 @@ def get_long_description():
 sqlglot_lib = {
  # Using an Acryl fork of sqlglot.
  # https://github.com/tobymao/sqlglot/compare/main...hsheth2:sqlglot:hsheth?expand=1
- "acryl-sqlglot==16.7.6.dev6",
+ "acryl-sqlglot==18.0.2.dev15",
 }
 
 aws_common = {

diff --git a/metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_unnest_columns.json b/metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_unnest_columns.json
@@ -1,16 +1,8 @@
 {
  "query_type": "SELECT",
  "in_tables": [
- {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table1"
- },
- {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table2"
- }
+ "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table1,PROD)",
+ "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table2,PROD)"
  ],
  "out_tables": [],
  "column_lineage": [
@@ -21,11 +13,7 @@
  },
  "upstreams": [
  {
- "table": {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table1"
- },
+ "table": "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table1,PROD)",
  "column": "reporting_day"
  }
  ]
@@ -37,19 +25,11 @@
  },
  "upstreams": [
  {
- "table": {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table1"
- },
+ "table": "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table1,PROD)",
  "column": "by_product.product_code"
  },
  {
- "table": {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table2"
- },
+ "table": "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table2,PROD)",
  "column": "other_field"
  }
  ]
@@ -61,11 +41,7 @@
  },
  "upstreams": [
  {
- "table": {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table2"
- },
+ "table": "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table2,PROD)",
  "column": "other_field"
  }
  ]
@@ -77,11 +53,7 @@
  },
  "upstreams": [
  {
- "table": {
- "database": "bq-proj",
- "db_schema": "dataset",
- "table": "table1"
- },
+ "table": "urn:li:dataset:(urn:li:dataPlatform:bigquery,bq-proj.dataset.table1,PROD)",
  "column": "by_product.product_code_dau"
  }
  ]

diff --git a/metadata-ingestion/tests/unit/sql_parsing/goldens/test_create_view_as_select.json b/metadata-ingestion/tests/unit/sql_parsing/goldens/test_create_view_as_select.json
@@ -15,7 +15,7 @@
  "upstreams": [
  {
  "table": "urn:li:dataset:(urn:li:dataPlatform:oracle,scott.emp,PROD)",
- "column": "deptno"
+ "column": "DEPTNO"
  }
  ]
  },
@@ -34,7 +34,7 @@
  "upstreams": [
  {
  "table": "urn:li:dataset:(urn:li:dataPlatform:oracle,scott.emp,PROD)",
- "column": "sal"
+ "column": "SAL"
  }
  ]
  }

diff --git a/metadata-ingestion/tests/unit/sql_parsing/goldens/test_select_with_ctes.json b/metadata-ingestion/tests/unit/sql_parsing/goldens/test_select_with_ctes.json
@@ -9,24 +9,24 @@
  {
  "downstream": {
  "table": null,
- "column": "col1"
+ "column": "COL1"
  },
  "upstreams": [
  {
  "table": "urn:li:dataset:(urn:li:dataPlatform:oracle,table1,PROD)",
- "column": "col1"
+ "column": "COL1"
  }
  ]
  },
  {
  "downstream": {
  "table": null,
- "column": "col3"
+ "column": "COL3"
  },
  "upstreams": [
  {
  "table": "urn:li:dataset:(urn:li:dataPlatform:oracle,table2,PROD)",
- "column": "col3"
+ "column": "COL3"
  }
  ]
  }