Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move clip models #945

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

chore: move clip models #945

wants to merge 16 commits into from

Conversation

selmiss
Copy link
Contributor

@selmiss selmiss commented Dec 29, 2023

No description provided.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ca2b25b) 70.73% compared to head (3ac7d2b) 71.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
server/clip_server/model/clip_onnx.py 81.81% 2 Missing ⚠️
server/clip_server/model/pretrained_models.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   70.73%   71.71%   +0.98%     
==========================================
  Files          23       23              
  Lines        1565     1584      +19     
==========================================
+ Hits         1107     1136      +29     
+ Misses        458      448      -10     
Flag Coverage Δ
cas 71.71% <84.61%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@selmiss selmiss marked this pull request as draft January 5, 2024 11:54
@selmiss
Copy link
Contributor Author

selmiss commented Jan 15, 2024

All the torch models have been migrated and tested. The onnx models will be migrated later due to my network.

@selmiss selmiss marked this pull request as ready for review January 15, 2024 05:22
@selmiss selmiss requested a review from numb3r3 January 15, 2024 05:22
@selmiss selmiss requested review from ZiniuYu and removed request for numb3r3 January 15, 2024 17:00
@selmiss
Copy link
Contributor Author

selmiss commented Jan 16, 2024

What's the 'codecov' problem? Do you think that needs a unit test to cover?

@selmiss
Copy link
Contributor Author

selmiss commented Jan 19, 2024

All the onnx and torch models have been transferred to huggingface successfully by now.

@selmiss selmiss requested a review from numb3r3 January 19, 2024 10:35
server/clip_server/model/clip_onnx.py Outdated Show resolved Hide resolved
server/clip_server/model/pretrained_models.py Outdated Show resolved Hide resolved
server/clip_server/model/clip_onnx.py Outdated Show resolved Hide resolved
@selmiss selmiss requested a review from ZiniuYu January 22, 2024 08:40
Copy link
Contributor Author

@selmiss selmiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished remove s3 download address

@selmiss selmiss requested a review from ZiniuYu January 23, 2024 10:51
@@ -43,7 +43,7 @@
setup_requires=['setuptools>=18.0', 'wheel'],
install_requires=[
'jina>=3.12.0',
'docarray[common]>=0.19.0,<0.30.0',
'docarray[common]==0.21.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirement is too strong. Could we have some flexible version bump here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants