Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: torchvision version to avoid compatibility issue #866

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

jemmyshin
Copy link
Member

This pr resolves the issue. We fix the torchvision version to avoid this.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #866 (fbc72de) into main (0223e6f) will decrease coverage by 2.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   80.28%   78.26%   -2.03%     
==========================================
  Files          22       22              
  Lines        1633     1633              
==========================================
- Hits         1311     1278      -33     
- Misses        322      355      +33     
Flag Coverage Δ
cas 78.26% <ø> (-2.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

server/setup.py Outdated
@@ -45,7 +45,7 @@
'ftfy',
'torch',
'regex',
'torchvision',
'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about

Suggested change
'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision',
'torchvision==0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision',

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',

server/setup.py Outdated
@@ -45,7 +45,7 @@
'ftfy',
'torch',
'regex',
'torchvision',
'torchvision<=0.13.0' if sys.version_info == (3, 7, 0) else 'torchvision',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',

server/setup.py Show resolved Hide resolved
@@ -45,7 +45,7 @@
'ftfy',
'torch',
'regex',
'torchvision',
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'torchvision<=0.13.0' if sys.version_info <= (3, 7, 2) else 'torchvision',
'torchvision<=0.13.0' if sys.version_info[:2] <= (3, 7) else 'torchvision',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between these two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.7.x: x ∈ [0, 15]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@numb3r3 numb3r3 merged commit 67f551c into main Nov 25, 2022
@numb3r3 numb3r3 deleted the fix-torchvision-compatibility branch November 25, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants