-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export ColorActionName enum #1205
Merged
hipstersmoothie
merged 3 commits into
jimp-dev:main
from
daniellwdb:feat/color-action-name-enum
Feb 24, 2023
Merged
Export ColorActionName enum #1205
hipstersmoothie
merged 3 commits into
jimp-dev:main
from
daniellwdb:feat/color-action-name-enum
Feb 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
requested changes
Feb 22, 2023
hipstersmoothie
approved these changes
Feb 24, 2023
🚀 PR was released in |
This was referenced May 24, 2024
This was referenced May 25, 2024
This was referenced May 29, 2024
This was referenced Aug 10, 2024
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
This PR fixes #987 by exporting an enum with all possible values for the
color
method's apply parameters. I chose to use an enum because this makes refactoring easier compared to having plain strings. Originally theColorActionName
type was missing some values.What else might be affected
This is a breaking change for projects using TypeScript because they would have to reference the enum directly and use their values.
Some possible fix for backwards compatibility (>TS4.1):
If older versions need to be supported I can try to look into it.
Tasks
jimp.d.ts