Add support for DateTimeImmutable objects #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
reviewed
Aug 10, 2019
| @@ -1,2 +1,3 @@ | |||
| composer.lock | |||
There was a problem hiding this comment.
The composer.lock is ignored and I guess we don't need this repository to cache dependencies version.
And I think the composer.lock is also remove from Git version control.
There was a problem hiding this comment.
Adding the composer.lock file to version control is useful if you have a lot of dependencies so you can track down which dependencies might have broken and not respecting semver. Since time-ago doesn't rely on any dependency (except dev dependencies) it's pretty much useless to include it.
peter279k
approved these changes
Aug 10, 2019
|
This is a very good change 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
DateTimeImmutableobjects by using theDateTimeInterfacewhere needed.