fix a likely GC root bug in jl_gf_invoke

jiahao · Jan 5, 2015 · df846de · df846de
1 parent d757543
commit df846de
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/gf.c b/src/gf.c
@@ -1707,7 +1707,7 @@ jl_value_t *jl_gf_invoke(jl_function_t *gf, jl_tuple_t *types,
  jl_tuple_t *tpenv=jl_null;
  jl_tuple_t *newsig=NULL;
  jl_tuple_t *tt=NULL;
- JL_GC_PUSH3(&env, &newsig, &tt);
+ JL_GC_PUSH3(&tpenv, &newsig, &tt);
 
  if (m->invokes == JL_NULL) {
  m->invokes = new_method_table(mt->name);
@@ -1719,7 +1719,7 @@ jl_value_t *jl_gf_invoke(jl_function_t *gf, jl_tuple_t *types,
 
  newsig = (jl_tuple_t*)m->sig;
 
- if (env != (jl_value_t*)jl_false) {
+ if (m->tvars != jl_null) {
  jl_value_t *ti =
  lookup_match((jl_value_t*)tt, (jl_value_t*)m->sig, &tpenv, m->tvars);
  assert(ti != (jl_value_t*)jl_bottom_type);