Merge pull request JuliaLang#14627 from mmaxs/fix-MethodError-for-con…

…nect

fix MethodError for connect(addr::Base.InetAddr{T<:Base.IPAddr})

base/socket.jl

@@ -654,6 +654,8 @@ function connect!(sock::TCPSocket, host::IPv6, port::Integer)
  sock.status = StatusConnecting
 end
 
+connect!(sock::TCPSocket, addr::InetAddr) = connect!(sock, addr.host, addr.port)
+
 # Default Host to localhost
 connect(sock::TCPSocket, port::Integer) = connect(sock,IPv4(127,0,0,1),port)
 connect(port::Integer) = connect(IPv4(127,0,0,1),port)

test/socket.jl

@@ -289,3 +289,33 @@ let P = Pipe()
  @test !isopen(P)
  @test eof(P)
 end
+
+# test the method matching connect!(::TCPSocket, ::Base.InetAddr{T<:Base.IPAddr})
+let
+ addr = Base.InetAddr(ip"127.0.0.1", 4444)
+
+ function test_connect(addr::Base.InetAddr)
+ srv = listen(addr)
+
+ @async try c = accept(srv); close(c) catch end
+ yield()
+
+ t0 = TCPSocket()
+ t = t0
+ @assert is(t,t0)
+
+ try
+ t = connect(addr)
+ finally
+ close(srv)
+ end
+
+ test = !is(t,t0)
+ close(t)
+
+ return test
+ end
+
+ @test test_connect(addr)
+end
+