Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default subtitle from hls #688

Merged
merged 2 commits into from
Sep 15, 2021
Merged

set default subtitle from hls #688

merged 2 commits into from
Sep 15, 2021

Conversation

siloebb
Copy link
Contributor

@siloebb siloebb commented Sep 2, 2021

fix #687
This pull request make HLS video set the default subtitle using DEFAULT=YES, so when is set the subtitle will start by default.

lib/src/hls/better_player_hls_utils.dart Outdated Show resolved Hide resolved
lib/src/hls/better_player_hls_utils.dart Outdated Show resolved Hide resolved
lib/src/hls/hls_parser/format.dart Outdated Show resolved Hide resolved
lib/src/hls/better_player_hls_utils.dart Show resolved Hide resolved
@siloebb
Copy link
Contributor Author

siloebb commented Sep 13, 2021

I made another PR removing the unecessary comments.
#687

@jhomlala jhomlala changed the base branch from master to feature/august_changes_2 September 15, 2021 16:25
@jhomlala
Copy link
Owner

LGTM thanks.

@jhomlala jhomlala merged commit 55a9672 into jhomlala:feature/august_changes_2 Sep 15, 2021
jhomlala added a commit that referenced this pull request Sep 20, 2021
* Added expandToFill parameter in BetterPlayerConfiguration

* Updated changelog

* * Added `BetterPlayerControlsConfiguration.theme` factory for `BetterPlayerControlsConfiguration`.

* Added null checks in seek commands in BetterPlayerControlsState.

* Fixed issue with live stream where player controls were always visible.

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Added tests to CI

* Update ci.yml

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Updated tests, general refactor

* Updated cupertino theme

* Fixed iOS seek issue

* Fix iOS caching + add iOS feature: preCaching (#670)

* Fix iOS caching + add iOS feature: preCaching

* Added required changes

* Fix compile issues

* Added stop pre cache iOS implementation

* Updated caching implementation

* Updated caching implementation

* Updated caching implementation

* Updated caching implementation

* Updated documentation

* Fixed video FPS hardcoded to 30 on iOs (#705)

Co-authored-by: Jakub <[email protected]>

* Updated changelog

* set default subtitle from hls (#688)

* set default subtitle from hls

* remove comments

* General refactor

* Disabled analysis options.

* Flutter 2.5 update

* Flutter 2.5 update

* Disabled lint

* Fixed analyzer

* Updated dependencies

* Updated version

Co-authored-by: themadmrj <[email protected]>
Co-authored-by: Anton Krasov <[email protected]>
Co-authored-by: Siloe Bezerra Bispo <[email protected]>
geriby23 pushed a commit to threadable/betterplayer that referenced this pull request Jul 16, 2024
* Added expandToFill parameter in BetterPlayerConfiguration

* Updated changelog

* * Added `BetterPlayerControlsConfiguration.theme` factory for `BetterPlayerControlsConfiguration`.

* Added null checks in seek commands in BetterPlayerControlsState.

* Fixed issue with live stream where player controls were always visible.

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Added tests to CI

* Update ci.yml

* Updated tests

* Updated tests

* Updated tests

* Updated tests

* Updated tests, general refactor

* Updated cupertino theme

* Fixed iOS seek issue

* Fix iOS caching + add iOS feature: preCaching (jhomlala#670)

* Fix iOS caching + add iOS feature: preCaching

* Added required changes

* Fix compile issues

* Added stop pre cache iOS implementation

* Updated caching implementation

* Updated caching implementation

* Updated caching implementation

* Updated caching implementation

* Updated documentation

* Fixed video FPS hardcoded to 30 on iOs (jhomlala#705)

Co-authored-by: Jakub <[email protected]>

* Updated changelog

* set default subtitle from hls (jhomlala#688)

* set default subtitle from hls

* remove comments

* General refactor

* Disabled analysis options.

* Flutter 2.5 update

* Flutter 2.5 update

* Disabled lint

* Fixed analyzer

* Updated dependencies

* Updated version

Co-authored-by: themadmrj <[email protected]>
Co-authored-by: Anton Krasov <[email protected]>
Co-authored-by: Siloe Bezerra Bispo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] HLS don't start with or give access to know which subtitle is the default
2 participants