Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links from inside links in mediawiki writer #8739

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

wgevaert
Copy link
Contributor

Fixes issue #8738

I am not sure if this is the most desired way to do it.

Other thing to consider:

removeLinks :: [Inline] -> [Inline]
removeLinks = walk go
 where
  go (Link _ ils _) = Underline ils
  go x = x

@jgm
Copy link
Owner

jgm commented Mar 30, 2023

Looks good to me! Maybe add a command test? See test/commands for the format.
Name it after the issue number.

Use the pandoc walk function, similar to what html writer does
@wgevaert wgevaert force-pushed the main branch 2 times, most recently from 071662e to 4d534fc Compare March 31, 2023 12:49
test/command/8738.md Outdated Show resolved Hide resolved
Use native as input and mediawiki as output.
@wgevaert
Copy link
Contributor Author

wgevaert commented Apr 5, 2023

Anything else I have to do or can it be merged?

@jgm
Copy link
Owner

jgm commented Apr 5, 2023

looks good!

@jgm jgm merged commit ce4e4d2 into jgm:main Apr 5, 2023
Flupp pushed a commit to Flupp/pandoc that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants