fix: local namespace limit size and unhashable types #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #79 by not building a
set
from a render context's local namespace values when calculating its size. I'm not sure what I was thinking there 😞.I also recognise that using
sys.getsizeof()
to calculate the "size" of a render context namespace is not always appropriate.Context._get_size_of_locals()
has been renamed toContext.get_size_of_locals()
and is now considered part of the public API. See the comments on issue #79 for an example of customizing the local namespace limit calculation by overridingContext.get_size_of_locals()
.