Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GCR Client for GKE images which used to be hosted under google-containers #202

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

davidcollom
Copy link
Collaborator

This is related to #147

Actually https://gcr.io/v2/google-containers/kube-proxy-amd64/tags/list hasn't been updated for a long time because they switched to https://gke.gcr.io/v2/kube-proxy-amd64/tags/list and new images are published there.

Google has now stopped pushing to google-containers namespace and now all gcr URI's can have multiple nested paths or none what so ever under their own vanity domain (gke.gcr.io)

Copy link
Contributor

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have a release note but worth tagging this for the next minor version and mentioning incase people are still using it. I know they shouldn't but just deflect the issue back to GKE :)

@davidcollom
Copy link
Collaborator Author

Not sure if we have a release note but worth tagging this for the next minor version and mentioning incase people are still using it. I know they shouldn't but just deflect the issue back to GKE :)

@hawksight - We generate github release notes automatically on release 👍 - No one should be manually using these images, they're provided by GKE's system - I'd be very surprised if anyone is still on 1.18 of GKE 😬 as it was released 4 years ago! 🤯

@davidcollom davidcollom merged commit 422a249 into main Jul 3, 2024
4 checks passed
@davidcollom davidcollom deleted the gcr-gke-fix branch July 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants