Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BombenProdukt/typeid for PHP to README.md #18

Closed
wants to merge 3 commits into from
Closed

Add BombenProdukt/typeid for PHP to README.md #18

wants to merge 3 commits into from

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jul 3, 2023

I've begun an implementation for PHP, which you can find at https://github.com/BombenProdukt/typeid. The encoding and decoding implementation is based on https://github.com/jetpack-io/typeid-js. At present, it passes all encodings as per https://github.com/jetpack-io/typeid/blob/main/spec/valid.yml. We are running the tests directly against the valid.yml and invalid.yml files to promptly detect any failures. Tests for the invalid.yml file are still missing, but I plan to add them in the coming days as time allows.

Brian Faust added 3 commits July 3, 2023 12:24
@loreto
Copy link
Contributor

loreto commented Jul 3, 2023

@faustbrian Thanks for contributing, having a PHP implementation would be great!

Due to a quirk of our internal setup, I need to accept the PR in our opensource monorepo and then it'll automatically get published here. Do you mind opening the PR there? The corresponding file is here: https://github.com/jetpack-io/opensource/blob/main/typeid/typeid/README.md

I'm also trying to keep the list of implementations in alphabetical order, so add PHP in-between Java and Python.

@faustbrian
Copy link
Contributor Author

@faustbrian faustbrian closed this Jul 3, 2023
@faustbrian faustbrian deleted the patch-1 branch July 3, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants