-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: downgrade jest-snapshot#semver to v6 to support node 8 #9451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9451 +/- ##
=======================================
Coverage 64.96% 64.96%
=======================================
Files 283 283
Lines 12104 12104
Branches 2990 2990
=======================================
Hits 7863 7863
Misses 3604 3604
Partials 637 637 Continue to review full report at Codecov.
|
Whoops, my bad! I read "Drop support for very old node versions" in the changelog which was before 8 was EOL and just assumed it didn't include node 8 |
@@ -92,7 +92,7 @@ | |||
"lint:prettier": "yarn --silent lint:prettier:ci --fix", | |||
"lint:prettier:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore", | |||
"postinstall": "opencollective postinstall && yarn build", | |||
"install-no-ts-build": "node scripts/remove-postinstall && yarn --no-progress --frozen-lockfile --ignore-engines && node scripts/build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hid the error. not sure why we even had it here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@SimenB Are there plans to release this in a patch release soon? |
I wanna get #9457 fixed first, then I'll start poking people for a patch release. It's unfortunately a lot of work getting a release out 🙁 You can use |
@SimenB Thanks for the reply; sounds good. I'm asking on behalf of a library that depends on Jest and I'm trying to upgrade its dependencies in an effort to make it compatible with Jest v25, so unfortunately I can't use |
Any update about a new release? #9457 seems not to be an easy fix and there are no comments since 22 days. We would like to upgrade our dependecies without the |
25.2.0 published |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Downgrades the semver dependency in
jest-snapshot
to a version that supports node 8.Fixes #9450
Test plan
N/A