Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @babel/code-frame #14976

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Update @babel/code-frame #14976

merged 2 commits into from
Mar 19, 2024

Conversation

nicolo-ribaudo
Copy link
Contributor

Summary

There are some changes in how Babel emits ANSI colors. The rendered output is the same, but the sequences differ.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 468b45d
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65f978001e18e0000723063b
😎 Deploy Preview https://deploy-preview-14976--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

e2e/runJest.ts Outdated
Comment on lines 89 to 90
NO_COLOR: '1',
FORCE_COLOR: '0',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, while opening this PR I caught a potential regression in Babel. There is no agreed-upon meaning on what FORCE_COLOR does: according to some it should always force color (https://force-color.org/), because NO_COLOR always unconditionally disables color and they are opposites. According to others, FORCE_COLOR=0 should disable colors.

Apparently Babel switched from one to the other, so I added this NO_COLOR=1 just to make sure that e2e tests aren't full of colors until when we decide what to do.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit d4d1f2b into jestjs:main Mar 19, 2024
73 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the up-code-frame branch March 19, 2024 16:05
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants