Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@jest/reporters): GitHubActionsReporter version 2 #12822

Closed

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented May 8, 2022

Summary

Annotations from GitHubActionsReporter is a great feature. Let’s make it even better:

  • add the annotations after each test case (instead of at the end of run);
  • strip internal stack traces;
  • no leading Error;
  • and title (perhaps?).

There is more. @martinwoodward drop me a message saying that GitHub Actions soon will have a possibility to add a job summary. Would it be interested to try out this upcoming feature? Sure, let’s try it right out now. Thanks, Martin!

Test plan

Unit test are added. Also some temporary failing tests are included to see the output.

@SimenB
Copy link
Member

SimenB commented May 8, 2022

Exciting!

Where is this summary printed? Can't find it 😅

@mrazauskas
Copy link
Contributor Author

Where is this summary printed? Can't find it 😅

Here (under all annotations): https://github.com/facebook/jest/actions/runs/2288677934

It must be markdown. So I used badges to bring in some colors (inspired by Renovate). Will improve it a bit.

@mrazauskas
Copy link
Contributor Author

I will split annotation to separate PR. Perhaps that will help to see what is wrong.

Now about summaries. They look like this:

Screenshot 2022-05-08 at 18 04 20

Screenshot 2022-05-08 at 18 04 35

Each step in a job gets a summary. That’s a lot of summaries in this repo. For instance, TS summary at first looks duplicated. It is not (; These are two steps: type test on latest TS and type tests on TS 4.3. Actual duration looks rather odd, but apparently it is correct.

Seems like these can be useful to check quickly what is happening. I will try to add few details, e.g. a link to jump directly to a log of some failing jobs would be nice.

Ah.. Link to summaries (they live at the bottom, under all annotations): https://github.com/facebook/jest/actions/runs/2289939027

@SimenB
Copy link
Member

SimenB commented May 15, 2022

@mrazauskas
Copy link
Contributor Author

Thanks! It would be really cool to have a result like in their picture.

@SimenB
Copy link
Member

SimenB commented Jun 3, 2022

@mrazauskas what's the status here? 🙂

@mrazauskas
Copy link
Contributor Author

Oh.. I was playing with svg's and got overexcited ;D I look go through the experiments and will try to wrap this up next week.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Oct 4, 2022
@mrazauskas
Copy link
Contributor Author

Not sure this is really useful. It needs more thinking and adds a lot of code as well. Closing for now.

@mrazauskas mrazauskas closed this Oct 19, 2022
@mrazauskas mrazauskas deleted the feat-github-actions-reporter-2 branch November 8, 2022 11:13
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants