feat(valid-title): allow custom matcher messages #913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if maybe we should drop support for taking a string in favor of always passing a tuple (with or without the second item), as it'd make things a bit lighter for us by making the usage more consistent (both in code and docs) 馃
I think a good follow-up feature would be to support multiple matchers, so that you can reduce the complexity of single regexps + have more specific messages (implementation wise, this'd be that we support taking in an array of
MatcherAndMessage
& change our logic to do iterate over eachMatcherAndMessage
).Slightly annoyingly, we could almost deprecate
lowercase-name
in favor of this rule since you could use/[^A-Z]/u.source
except that would also apply to top-level describes.Fixes #688