Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create max-nested-describe rule #845

Merged
merged 14 commits into from
Jul 21, 2021
Merged

feat: create max-nested-describe rule #845

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
90e5eb6
feat: create max-nested-describe rule
dominictwlee May 19, 2021
45af21d
feat: support only object schema
dominictwlee May 24, 2021
90cb912
refactor: simplify call expression type check
dominictwlee May 24, 2021
70ce266
test: max 0 option
dominictwlee May 24, 2021
c4eab3e
test: update number of rules
dominictwlee May 24, 2021
0fe42c0
test: update snapshot
dominictwlee May 24, 2021
454bf0b
test: describe modifiers
dominictwlee May 24, 2021
41c5dfc
docs: fix examples syntax
dominictwlee May 24, 2021
efdc70f
docs: fix syntax consistency
dominictwlee May 24, 2021
3fc9233
test: fix missing brackets
dominictwlee May 24, 2021
b4aa411
refactor: add spacing around message placeholders
dominictwlee May 24, 2021
313f75a
feat: increase default max to 5
dominictwlee Jul 4, 2021
4805330
docs: update with new default max of 5
dominictwlee Jul 4, 2021
d5bb697
test: add cases for 5 max
dominictwlee Jul 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add cases for 5 max
  • Loading branch information
@dominictwlee
dominictwlee committed Jul 4, 2021
commit d5bb697ff49a932c4191c8f1af5cb48f48ade369
86 changes: 56 additions & 30 deletions src/rules/__tests__/max-nested-describe.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,27 +13,39 @@ const ruleTester = new TSESLint.RuleTester({
ruleTester.run('max-nested-describe', rule, {
G-Rath marked this conversation as resolved.
Show resolved Hide resolved
valid: [
dedent`
describe('foo', () => {
describe('bar', () => {
it('hello', async () => {
expect('hello').toBe('hello');
});
});
describe('foo', function() {
describe('bar', function () {
describe('baz', function () {
describe('qux', function () {
describe('qux', function () {
it('should get something', () => {
expect(getSomething()).toBe('Something');
});
})
})
})
})
});
`,
dedent`
describe('foo', () => {
describe('bar', () => {
it('hello', async () => {
expect('hello').toBe('hello');
});
});
describe('foo', function() {
describe('bar', function () {
describe('baz', function () {
describe('qux', function () {
describe('qux', function () {
it('should get something', () => {
expect(getSomething()).toBe('Something');
});
});

fdescribe('qux', () => {
it('something', async () => {
expect('something').toBe('something');
});
});
fdescribe('qux', () => {
it('something', async () => {
expect('something').toBe('something');
});
});
})
})
})
});
`,
dedent`
Expand Down Expand Up @@ -96,26 +108,39 @@ ruleTester.run('max-nested-describe', rule, {
describe('bar', function () {
describe('baz', function () {
describe('qux', function () {
it('should get something', () => {
expect(getSomething()).toBe('Something');
describe('quxx', function () {
describe('over limit', function () {
it('should get something', () => {
expect(getSomething()).toBe('Something');
});
});
});
})
})
})
});
});
});
});
`,
errors: [
{ messageId: 'exceededMaxDepth', line: 3, column: 5 },
{ messageId: 'exceededMaxDepth', line: 4, column: 7 },
],
errors: [{ messageId: 'exceededMaxDepth', line: 6, column: 11 }],
},
{
code: dedent`
describe('foo', () => {
describe('bar', () => {
describe('baz', () => {
it('should get something', () => {
expect(getSomething()).toBe('Something');
describe('baz1', () => {
describe('baz2', () => {
describe('baz3', () => {
it('should get something', () => {
expect(getSomething()).toBe('Something');
});
});

describe('baz4', () => {
it('should get something', () => {
expect(getSomething()).toBe('Something');
});
});
});
});
});

Expand All @@ -128,8 +153,8 @@ ruleTester.run('max-nested-describe', rule, {
});
`,
errors: [
{ messageId: 'exceededMaxDepth', line: 3, column: 5 },
{ messageId: 'exceededMaxDepth', line: 9, column: 5 },
{ messageId: 'exceededMaxDepth', line: 6, column: 11 },
{ messageId: 'exceededMaxDepth', line: 12, column: 11 },
],
},
{
Expand All @@ -156,6 +181,7 @@ ruleTester.run('max-nested-describe', rule, {
});
});
`,
options: [{ max: 2 }],
errors: [
{ messageId: 'exceededMaxDepth', line: 3, column: 5 },
{ messageId: 'exceededMaxDepth', line: 9, column: 5 },
Expand Down