Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support all variations of describe, it, & test #792

Merged
merged 11 commits into from
Apr 5, 2021
Merged

fix: support all variations of describe, it, & test #792

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16b507a
refactor(utils): support matching all variations of `describe` & `test`
G-Rath Mar 14, 2021
fe43744
test(consistent-test-it): add case for `describe.only.each`
G-Rath Mar 16, 2021
915e3ff
test(require-top-level-describe): add cases for modifiers and `each`
G-Rath Apr 3, 2021
4ba6271
test(no-conditional-expect): add cases for `.each` with template literal
G-Rath Apr 4, 2021
3444b5b
test(no-export): add cases for `.each`
G-Rath Apr 4, 2021
8984a1d
test(no-if): add cases for `.each` calls
G-Rath Apr 4, 2021
e113082
test(no-test-return-statement): add cases for `.each`
G-Rath Apr 4, 2021
484de05
test(prefer-hooks-on-top): add cases for `.each`
G-Rath Apr 4, 2021
5803d4b
test(valid-title): add cases for `.each`
G-Rath Apr 4, 2021
6211dbb
test(utils): deduplicate code
G-Rath Apr 4, 2021
4ced9af
test(utils): refactor to deduplicate code
G-Rath Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(consistent-test-it): add case for describe.only.each
  • Loading branch information
@G-Rath
G-Rath committed Apr 4, 2021
commit fe4374481ea624ed1f4a7d23bcf6c5610d1fd9df
26 changes: 26 additions & 0 deletions src/rules/__tests__/consistent-test-it.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,32 @@ ruleTester.run('consistent-test-it with fn=test', rule, {
},
],
},
{
code: dedent`
describe.only.each()("%s", () => {
test("is valid, but should not be", () => {});
it("is not valid, but should be", () => {});
});
`,
output: dedent`
describe.only.each()("%s", () => {
it("is valid, but should not be", () => {});
it("is not valid, but should be", () => {});
});
`,
options: [{ fn: TestCaseName.test, withinDescribe: TestCaseName.it }],
errors: [
{
messageId: 'consistentMethodWithinDescribe',
data: {
testKeywordWithinDescribe: TestCaseName.it,
oppositeTestKeyword: TestCaseName.test,
},
},
],
},
{
code: 'describe("suite", () => { it("foo") })',
output: 'describe("suite", () => { test("foo") })',
Expand Down