Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade prettier #1402

Merged
merged 2 commits into from
Jul 13, 2023
Merged

chore: upgrade prettier #1402

merged 2 commits into from
Jul 13, 2023

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 13, 2023

They still support Node 14, so this is safe: https://prettier.io/blog/2023/07/05/3.0.0.html#api-1

eslint: ">=7.28.0"
prettier: ">=2.0.0"
"@types/eslint": ">=8.0.0"
eslint: ">=8.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this might actually stop us as we still support ESLint 7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, so I guess it doesn't matter. This isn't exposed outside of this repo anyways

@SimenB SimenB merged commit 3347fc5 into main Jul 13, 2023
26 checks passed
@SimenB SimenB deleted the upgrade-prettier branch July 13, 2023 15:00
@github-actions
Copy link

🎉 This PR is included in version 27.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant