Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: produce valid code when when fixing properties accessed with square brackets #1131

Merged
merged 6 commits into from
May 29, 2022
Merged

fix: produce valid code when when fixing properties accessed with square brackets #1131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ecd4dd
fix(prefer-todo): support fixing indexed property access
G-Rath May 28, 2022
db42468
fix(prefer-to-be): support fixing indexed property access
G-Rath May 28, 2022
1d0bd68
fix(no-alias-methods): support fixing indexed property access
G-Rath May 28, 2022
a55f016
fix(prefer-strict-equal): support fixing indexed property access
G-Rath May 29, 2022
395ff63
refactor: use helper for wrapping text in quotes
G-Rath May 29, 2022
595e570
refactor(prefer-todo): reduce code a little
G-Rath May 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(prefer-todo): support fixing indexed property access
  • Loading branch information
@G-Rath
G-Rath committed May 28, 2022
commit 5ecd4dd080dbbcbdb7d75da31e90d506959f83f5
10 changes: 10 additions & 0 deletions src/rules/__tests__/prefer-todo.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,15 @@ ruleTester.run('prefer-todo', rule, {
output: 'test.todo("i need to write this test");',
errors: [{ messageId: 'emptyTest' }],
},
{
code: `test["skip"]("i need to write this test", function() {});`,
output: 'test[\'todo\']("i need to write this test");',
errors: [{ messageId: 'emptyTest' }],
},
{
code: `test[\`skip\`]("i need to write this test", function() {});`,
output: 'test[\'todo\']("i need to write this test");',
errors: [{ messageId: 'emptyTest' }],
},
],
});
20 changes: 9 additions & 11 deletions src/rules/prefer-todo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,18 @@ function createTodoFixer(
jestFnCall: ParsedJestFnCall,
fixer: TSESLint.RuleFixer,
) {
const fixes = [
fixer.replaceText(jestFnCall.head.node, `${jestFnCall.head.local}.todo`),
];

if (jestFnCall.members.length) {
fixes.unshift(
fixer.removeRange([
jestFnCall.head.node.range[1],
jestFnCall.members[0].range[1],
]),
);
const text =
jestFnCall.members[0].type === AST_NODE_TYPES.Identifier
? 'todo'
: "'todo'";

return [fixer.replaceText(jestFnCall.members[0], text)];
}

return fixes;
return [
fixer.replaceText(jestFnCall.head.node, `${jestFnCall.head.local}.todo`),
];
}

const isTargetedTestCase = (jestFnCall: ParsedJestFnCall): boolean => {
Expand Down