chore: upgrade to typescript 5 (#1365)

jest-community · Apr 18, 2023 · a058f22 · a058f22
1 parent e1965a2
commit a058f22
Show file tree

Hide file tree

Showing 43 changed files with 123 additions and 84 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -30,6 +30,11 @@ module.exports = {
  '@typescript-eslint/no-require-imports': 'error',
  '@typescript-eslint/ban-ts-comment': 'warn',
  '@typescript-eslint/ban-types': 'error',
+ '@typescript-eslint/consistent-type-imports': [
+ 'error',
+ { disallowTypeAnnotations: false, fixStyle: 'inline-type-imports' },
+ ],
+ '@typescript-eslint/no-import-type-side-effects': 'error',
  '@typescript-eslint/no-unused-vars': 'error',
  'eslint-comments/no-unused-disable': 'error',
  'eslint-plugin/require-meta-docs-description': [

diff --git a/package.json b/package.json
@@ -141,7 +141,7 @@
  "semantic-release": "^20.0.0",
  "semver": "^7.3.5",
  "ts-node": "^10.2.1",
- "typescript": "^4.4.0"
+ "typescript": "^5.0.4"
  },
  "peerDependencies": {
  "@typescript-eslint/eslint-plugin": "^5.0.0",

diff --git a/src/rules/__tests__/no-deprecated-functions.test.ts b/src/rules/__tests__/no-deprecated-functions.test.ts
@@ -1,6 +1,9 @@
 import { TSESLint } from '@typescript-eslint/utils';
 import rule from '../no-deprecated-functions';
-import { JestVersion, detectJestVersion } from '../utils/detectJestVersion';
+import {
+ type JestVersion,
+ detectJestVersion,
+} from '../utils/detectJestVersion';
 
 jest.mock('../utils/detectJestVersion');
 

diff --git a/src/rules/__tests__/unbound-method.test.ts b/src/rules/__tests__/unbound-method.test.ts
@@ -1,5 +1,5 @@
 import path from 'path';
-import { ESLintUtils, TSESLint } from '@typescript-eslint/utils';
+import { ESLintUtils, type TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import type { MessageIds, Options } from '../unbound-method';
 

diff --git a/src/rules/consistent-test-it.ts b/src/rules/consistent-test-it.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  TestCaseName,
  createRule,

diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
@@ -3,7 +3,7 @@
  * MIT license, Remco Haszing.
  */
 
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  createRule,
  getNodeName,

diff --git a/src/rules/max-expects.ts b/src/rules/max-expects.ts
@@ -1,6 +1,6 @@
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 import {
- FunctionExpression,
+ type FunctionExpression,
  createRule,
  isTypeOfJestFnCall,
  parseJestFnCall,

diff --git a/src/rules/max-nested-describe.ts b/src/rules/max-nested-describe.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import { createRule, isTypeOfJestFnCall } from './utils';
 
 export default createRule({

diff --git a/src/rules/no-conditional-expect.ts b/src/rules/no-conditional-expect.ts
@@ -1,6 +1,6 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
- KnownCallExpression,
+ type KnownCallExpression,
  createRule,
  getTestCallExpressionsFromDeclaredVariables,
  isSupportedAccessor,

diff --git a/src/rules/no-deprecated-functions.ts b/src/rules/no-deprecated-functions.ts
@@ -1,6 +1,6 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
- JestVersion,
+ type JestVersion,
  createRule,
  detectJestVersion,
  getNodeName,

diff --git a/src/rules/no-done-callback.ts b/src/rules/no-done-callback.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import { createRule, getNodeName, isFunction, parseJestFnCall } from './utils';
 
 const findCallbackArg = (

diff --git a/src/rules/no-export.ts b/src/rules/no-export.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import { createRule, isTypeOfJestFnCall } from './utils';
 
 export default createRule({

diff --git a/src/rules/no-hooks.ts b/src/rules/no-hooks.ts
@@ -1,4 +1,4 @@
-import { HookName, createRule, parseJestFnCall } from './utils';
+import { type HookName, createRule, parseJestFnCall } from './utils';
 
 export default createRule<
  [Partial<{ allow: readonly HookName[] }>],

diff --git a/src/rules/no-if.ts b/src/rules/no-if.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  TestCaseName,
  createRule,

diff --git a/src/rules/no-large-snapshots.ts b/src/rules/no-large-snapshots.ts
@@ -1,5 +1,9 @@
 import { isAbsolute } from 'path';
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  createRule,
  getAccessorValue,

diff --git a/src/rules/no-standalone-expect.ts b/src/rules/no-standalone-expect.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  DescribeAlias,
  createRule,

diff --git a/src/rules/no-test-return-statement.ts b/src/rules/no-test-return-statement.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  createRule,
  getTestCallExpressionsFromDeclaredVariables,

diff --git a/src/rules/no-untyped-mock-factory.ts b/src/rules/no-untyped-mock-factory.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  createRule,
  getAccessorValue,

diff --git a/src/rules/prefer-comparison-matcher.ts b/src/rules/prefer-comparison-matcher.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  EqualityMatcher,
  createRule,

diff --git a/src/rules/prefer-each.ts b/src/rules/prefer-each.ts
@@ -1,5 +1,5 @@
 import type { TSESTree } from '@typescript-eslint/utils';
-import { JestFnType, createRule, parseJestFnCall } from './utils';
+import { type JestFnType, createRule, parseJestFnCall } from './utils';
 
 export default createRule({
  name: __filename,

diff --git a/src/rules/prefer-equality-matcher.ts b/src/rules/prefer-equality-matcher.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESLint } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESLint } from '@typescript-eslint/utils';
 import {
  EqualityMatcher,
  ModifierName,

diff --git a/src/rules/prefer-expect-assertions.ts b/src/rules/prefer-expect-assertions.ts
@@ -1,6 +1,10 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- ParsedExpectFnCall,
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
+import {
+ type ParsedExpectFnCall,
  createRule,
  getAccessorValue,
  isFunction,

diff --git a/src/rules/prefer-expect-resolves.ts b/src/rules/prefer-expect-resolves.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import { createRule, parseJestFnCall } from './utils';
 
 export default createRule({

diff --git a/src/rules/prefer-lowercase-title.ts b/src/rules/prefer-lowercase-title.ts
@@ -1,8 +1,8 @@
 import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- CallExpressionWithSingleArgument,
+ type CallExpressionWithSingleArgument,
  DescribeAlias,
- StringNode,
+ type StringNode,
  TestCaseName,
  createRule,
  getStringValue,

diff --git a/src/rules/prefer-mock-promise-shorthand.ts b/src/rules/prefer-mock-promise-shorthand.ts
@@ -1,7 +1,7 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
- AccessorNode,
- FunctionExpression,
+ type AccessorNode,
+ type FunctionExpression,
  createRule,
  getAccessorValue,
  getNodeName,

diff --git a/src/rules/prefer-snapshot-hint.ts b/src/rules/prefer-snapshot-hint.ts
@@ -1,5 +1,5 @@
 import {
- ParsedExpectFnCall,
+ type ParsedExpectFnCall,
  createRule,
  getAccessorValue,
  isStringNode,

diff --git a/src/rules/prefer-spy-on.ts b/src/rules/prefer-spy-on.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import { createRule, getNodeName } from './utils';
 
 const findNodeObject = (

diff --git a/src/rules/prefer-to-be.ts b/src/rules/prefer-to-be.ts
@@ -1,8 +1,12 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- AccessorNode,
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
+import {
+ type AccessorNode,
  EqualityMatcher,
- ParsedExpectFnCall,
+ type ParsedExpectFnCall,
  createRule,
  getAccessorValue,
  getFirstMatcherArg,

diff --git a/src/rules/prefer-to-contain.ts b/src/rules/prefer-to-contain.ts
@@ -1,8 +1,8 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
- CallExpressionWithSingleArgument,
+ type CallExpressionWithSingleArgument,
  EqualityMatcher,
- KnownCallExpression,
+ type KnownCallExpression,
  ModifierName,
  createRule,
  getAccessorValue,

diff --git a/src/rules/prefer-todo.ts b/src/rules/prefer-todo.ts
@@ -1,6 +1,10 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- ParsedJestFnCall,
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
+import {
+ type ParsedJestFnCall,
  createRule,
  getAccessorValue,
  hasOnlyOneArgument,

diff --git a/src/rules/require-hook.ts b/src/rules/require-hook.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  createRule,
  getNodeName,

diff --git a/src/rules/unbound-method.ts b/src/rules/unbound-method.ts
@@ -1,4 +1,8 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  createRule,
  findTopMostCallExpression,

diff --git a/src/rules/utils/__tests__/parseJestFnCall.test.ts b/src/rules/utils/__tests__/parseJestFnCall.test.ts
@@ -1,10 +1,10 @@
 import type { JSONSchemaForNPMPackageJsonFiles } from '@schemastore/package';
-import { TSESLint, TSESTree } from '@typescript-eslint/utils';
+import { TSESLint, type TSESTree } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import { espreeParser } from '../../__tests__/test-utils';
 import {
- ParsedJestFnCall,
- ResolvedJestFnWithNode,
+ type ParsedJestFnCall,
+ type ResolvedJestFnWithNode,
  createRule,
  getAccessorValue,
  isSupportedAccessor,

diff --git a/src/rules/utils/accessors.ts b/src/rules/utils/accessors.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 
 /**
  * A `Literal` with a `value` of type `string`.

diff --git a/src/rules/utils/followTypeAssertionChain.ts b/src/rules/utils/followTypeAssertionChain.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 
 export type MaybeTypeCast<Expression extends TSESTree.Expression> =
  | TSTypeCastExpression<Expression>

diff --git a/src/rules/utils/misc.ts b/src/rules/utils/misc.ts
@@ -2,17 +2,17 @@ import { parse as parsePath } from 'path';
 import {
  AST_NODE_TYPES,
  ESLintUtils,
- TSESLint,
- TSESTree,
+ type TSESLint,
+ type TSESTree,
 } from '@typescript-eslint/utils';
 import { version } from '../../../package.json';
 import {
- AccessorNode,
+ type AccessorNode,
  getAccessorValue,
  isSupportedAccessor,
 } from './accessors';
 import { followTypeAssertionChain } from './followTypeAssertionChain';
-import { ParsedExpectFnCall, isTypeOfJestFnCall } from './parseJestFnCall';
+import { type ParsedExpectFnCall, isTypeOfJestFnCall } from './parseJestFnCall';
 
 const REPO_URL = 'https://github.com/jest-community/eslint-plugin-jest';
 

diff --git a/src/rules/utils/parseJestFnCall.ts b/src/rules/utils/parseJestFnCall.ts
@@ -1,9 +1,13 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- AccessorNode,
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
+import {
+ type AccessorNode,
  DescribeAlias,
  HookName,
- KnownMemberExpression,
+ type KnownMemberExpression,
  ModifierName,
  TestCaseName,
  findTopMostCallExpression,

diff --git a/src/rules/valid-describe-callback.ts b/src/rules/valid-describe-callback.ts
@@ -1,4 +1,4 @@
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  createRule,
  getAccessorValue,

diff --git a/src/rules/valid-expect-in-promise.ts b/src/rules/valid-expect-in-promise.ts
@@ -1,6 +1,10 @@
-import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
 import {
- KnownCallExpression,
+ AST_NODE_TYPES,
+ type TSESLint,
+ type TSESTree,
+} from '@typescript-eslint/utils';
+import {
+ type KnownCallExpression,
  ModifierName,
  createRule,
  findTopMostCallExpression,

diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts
@@ -3,7 +3,7 @@
  * MIT license, Tom Vincent.
  */
 
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, type TSESTree } from '@typescript-eslint/utils';
 import {
  ModifierName,
  createRule,

diff --git a/src/rules/valid-title.ts b/src/rules/valid-title.ts
@@ -1,7 +1,11 @@
-import { AST_NODE_TYPES, JSONSchema, TSESTree } from '@typescript-eslint/utils';
+import {
+ AST_NODE_TYPES,
+ type JSONSchema,
+ type TSESTree,
+} from '@typescript-eslint/utils';
 import {
  DescribeAlias,
- StringNode,
+ type StringNode,
  TestCaseName,
  createRule,
  getStringValue,