Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when attempting to cherry pick with old key #3271

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jan 28, 2024

I wrote this feature and even I sometimes use the wrong key so I want to make this very clear to users so that there's no confusion.

We can get rid of this once users have had time to adjust

image

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

I wrote this feature and even I sometimes use the wrong key so I want
to make this very clear to users so that there's no confusion
@jesseduffield jesseduffield added the ignore-for-release This will exclude the PR from release notes label Jan 28, 2024
@jesseduffield
Copy link
Owner Author

Adding 'ignore for release' label because it's not really something that we need to call out in the release notes

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
0.00% (target: -2.00%) 52.63%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cf5d4d4) 47593 39684 83.38%
Head commit (e1aa68a) 47612 (+19) 39698 (+14) 83.38% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3271) 19 10 52.63%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jesseduffield jesseduffield merged commit 9b2a5f6 into master Jan 28, 2024
17 checks passed
@jesseduffield jesseduffield deleted the cherry-pick-keybinding-warning branch January 28, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release This will exclude the PR from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant