Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alternative confirmation and return keymappings #2495

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

mark2185
Copy link
Collaborator

@mark2185 mark2185 commented Mar 9, 2023

  • PR Description
    Discussed in this issue.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Uffizzi Preview Environment

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2495

⚙️ Updating now by workflow run 4373022742.

What is Uffizzi? Learn more

@jesseduffield jesseduffield merged commit a82d952 into master Mar 20, 2023
@jesseduffield jesseduffield deleted the feature/remove-altreturn branch March 20, 2023 09:11
@jesseduffield
Copy link
Owner

Nice work!

JelteF added a commit to JelteF/lazygit that referenced this pull request Jul 15, 2024
This partially adds the feature back that was removed in jesseduffield#2495. This
allows specifing a secondary Return keybinding. In my personal setup I
use the `q` for this (and remove it as the default for Quit). Returning
is a very common operation in lazygit, and having to reach for the
Escape key all the time is annoying. There are cases where it's not
possible to use a regular letter as the Return keybinding, such as the
commit prompt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants