-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling with the mouse wheel doesn't show past the first 'page' #2309
Comments
I noticed this as well, it's a bit of a showstopper bug for me as I rely on the diff information to review my own commits before pushing them, and I can't risk missing part of the changes. It definitely only started happening on v0.36.0, and it seems to happen regardless of the pager used. I was initially using Delta and thought the bug was related to that, but it happens with the default Git pager as well. |
I have the same bug. Windows 10 / lazygit 0.36.0 / git 2.38.1 |
524bf83 seems bad |
Gui.scrollDownView() is not called from VerticalScrollController.HandleScrollDown. |
Describe the bug
When I try to scroll through a diff using the scroll wheel of my mouse (actually using 2-finger scroll on my trackpad, but same difference) it just moves around the first page of the diff but doesn't load any further lines.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should scroll through the entire diff.
Screenshots
I don't have any screenshots on hand, unfortunately (proprietary source code and all that), but if I manage to get some I'll put them here.
Version info:
commit=, build date=, build source=homebrew, version=0.36.0, os=darwin, arch=amd64, git version=2.37.0 (Apple Git-136)
`git version 2.37.0 (Apple Git-136)
Additional context
This started happening when I updated to v0.36.0. My guess as to what's happening is that there was some change to the diff loading that made it only load in the minimal amount it needs to display the shown portion of the diff, and the scroll wheel isn't causing that buffer to update. This guess is based on the fact that when you scroll using the keyboard (select a diff, press enter, then use arrow keys) the size of the scroll bar shrinks as it loads more of the diff.
The text was updated successfully, but these errors were encountered: