fix unit test by setting empty string to href whenever the favicon is…

… not of type string (mattermost#1697)
jespino · Sep 17, 2018 · 1a516f6 · 1a516f6
1 parent ff4416e
commit 1a516f6
Show file tree

Hide file tree

Showing 3 changed files with 3,672 additions and 2 deletions.
diff --git a/components/sidebar/sidebar.jsx b/components/sidebar/sidebar.jsx
@@ -205,9 +205,9 @@ export default class Sidebar extends React.PureComponent {
  link.rel = 'shortcut icon';
  link.id = 'favicon';
  if (this.badgesActive) {
- link.href = redFavicon;
+ link.href = typeof redFavicon === 'string' ? redFavicon : '';
  } else {
- link.href = favicon;
+ link.href = typeof favicon === 'string' ? favicon : '';
  }
  var head = document.getElementsByTagName('head')[0];
  var oldLink = document.getElementById('favicon');