Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix tag trailing comma #715

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

FinalDoom
Copy link
Contributor

Filter empty tags when submitting a tag change via modal

Description

Empty tags are generally disallowed by input filtering, but a trailing comma is allowed in the tag input, which results in an empty tag. When submitted to the backend, this returns an error, and the modal hangs as loading.

This change will remove any empty tags, such as that generated by a trailing comma, prior to backend submission.

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20a672a) 73.15% compared to head (16e15b0) 73.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   73.15%   73.14%   -0.01%     
==========================================
  Files          62       62              
  Lines       11375    11375              
  Branches      959      958       -1     
==========================================
- Hits         8321     8320       -1     
- Misses       3040     3041       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes sending bad data to the backend when there is a trailing comma
@trim21 trim21 merged commit 748195a into jesec:master Jan 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants