feature: allow to replace main tracker of torrents #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb04fe3
to
cf52bca
Compare
|
Probably it should be hidden behind |
|
Relevant issues: Adding tracker will be much more difficult to manage. But while we are at here, it may be a good idea to take a look at it. Deleting tracker is a different story. rTorrent/libTorrent has no API to allow deletion of trackers. ruTorrent directly modifies torrents. It is dangerous and is not a good/stable approach. Let’s see if this is manageable via enable/disable interface. If not, an API change to rTorrent needs to be purposed and a fork might be necessary. |
rTorrent does not have function to remove trackers from torrents so we only disable existing tracker and insert the new one. This leads to duplicate listings of trackers in "Trackers" and "Filter by trackers". We can fix this later by only using enabled trackers for "Filter by" and "Torrent Details". Currently this feature only deals with the main tracker (index: 0). Combined with "Filter by trackers", it is ideal for a bulk change of tracker URL of private torrents due to a key leak or rotation. In the future, we can probably make the feature more sophisticated.
cf52bca
to
66c68b2
Compare
This would allow feature additions to proceed without worrying about making context menu too bloated. Plus, now developer can hide some more advanced or work-in-progress features by default.
66c68b2
to
f1e9daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rTorrent does not have function to remove trackers from torrents
so we only disable existing tracker and insert the new one.
This leads to duplicate listings of trackers in "Trackers" and
"Filter by trackers". We can fix this later by only using enabled
trackers for "Filter by" and "Torrent Details".
Currently this feature only deals with the main tracker (index: 0).
Combined with "Filter by trackers", it is ideal for a bulk change
of tracker URL of private torrents due to a key leak or rotation.
In the future, we can probably make the feature more sophisticated.